Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow communication between sessions of same user #1708

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

MoritzWeber0
Copy link
Member

A requirement for the training mode is that a Jupyter session can talk to a Capella session.

This PR adds network policies so that Pods can reach the ports of other Pods from the same user.

@MoritzWeber0 MoritzWeber0 force-pushed the allow-communication-between-user-sessions branch from 58638ad to 9323c34 Compare August 15, 2024 10:56
A requirement for the training mode is that a Jupyter session can talk
to a Capella session.

This PR adds network policies so that Pods can reach the ports of other
Pods from the same user.
@MoritzWeber0 MoritzWeber0 force-pushed the allow-communication-between-user-sessions branch from 9323c34 to 4906bab Compare August 15, 2024 11:21
Copy link

@MoritzWeber0 MoritzWeber0 enabled auto-merge August 15, 2024 11:23
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (d514394) to head (4906bab).
Report is 313 commits behind head on main.

Files with missing lines Patch % Lines
backend/capellacollab/sessions/operators/k8s.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   83.97%   83.96%   -0.02%     
==========================================
  Files         184      185       +1     
  Lines        6085     6105      +20     
  Branches      673      674       +1     
==========================================
+ Hits         5110     5126      +16     
- Misses        827      831       +4     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit a2a1902 into main Aug 15, 2024
28 of 29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the allow-communication-between-user-sessions branch August 15, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant